fix: add retry and logging for channel monitor migration#760
Open
fix: add retry and logging for channel monitor migration#760
Conversation
Member
Author
|
E2E Migration test |
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Member
Author
|
The force close wasn't displayed as Transfer Activity because the LDK node couldn't track the channel |
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds error tracking and retry logic for channel monitor retrieval during React Native to native Android migration, preventing silent channel loss.
Description
During migration from the RN app, channel monitors are fetched from the remote backup. Previously, if any monitor retrieval failed (network timeout, decryption error, etc.), it was silently dropped via
.mapNotNull(), potentially causing permanent channel loss without any indication to the user or in logs.This PR:
Preview
N/A - Backend migration logic, no UI changes
QA Notes
1. Migration with all monitors available
2. Log verification (requires simulated failure)
3. Regression - Normal operation